TorstenHettstedt/PHP-App-Timekeeping
1
0
Fork 0
Code Issues Pull Requests Projects Releases 3 Wiki Activity

Ergebnis bei *PHPStan* verbessert.

Browse Source
This commit is contained in:
Torstem_JetBrain
2021-04-06 11:15:25 +02:00
parent 5cdc11d9df
commit d11070ffbb
2 changed files with 14 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
api/src/Controller/HelloWorldController.php
+10 -2
View File
@@ -8,8 +8,16 @@ use Slim\Psr7\Request;
class HelloWorldController class HelloWorldController
{ {
/** @noinspection PhpUnusedParameterInspection */ /**
public function read(Request $request, Response $response, $args): Response * @param Request $request
* @param Response $response
* @param mixed[] $args
*
* @return Response
*
* @noinspection PhpUnusedParameterInspection
*/
public function read(Request $request, Response $response, array $args): Response
{ {
$payload = json_encode('Hallo World'); $payload = json_encode('Hallo World');
api/tests/unit/Repositories/WorkingHoursRepositoryTest.php
+4 -14
View File
@@ -9,7 +9,7 @@ use Exception;
use InvalidArgumentException; use InvalidArgumentException;
use PDO; use PDO;
use PDOStatement; use PDOStatement;
use stdClass; use TorstenHettstedt\TimekeepingApi\Models\ModelInterface;
use TorstenHettstedt\TimekeepingApi\Models\WorkingHours; use TorstenHettstedt\TimekeepingApi\Models\WorkingHours;
use TorstenHettstedt\TimekeepingApi\Repositories\RepositoryModelAlreadyExists; use TorstenHettstedt\TimekeepingApi\Repositories\RepositoryModelAlreadyExists;
use TorstenHettstedt\TimekeepingApi\Repositories\RepositoryRecordNotFoundException; use TorstenHettstedt\TimekeepingApi\Repositories\RepositoryRecordNotFoundException;
@@ -70,10 +70,7 @@ class WorkingHoursRepositoryTest extends Unit
public function testInsertWithInvalidModel(): void public function testInsertWithInvalidModel(): void
{ {
$repository = new WorkingHoursRepository($this->pdoObject); $repository = new WorkingHoursRepository($this->pdoObject);
$model = $this->make(stdClass::class, [ $model = $this->makeEmpty(ModelInterface::class);
'workingDay' => new DateTime(self::NEW_DATE),
'workingTime' => new DateInterval(self::NEW_INTERVAL),
]);
$this->expectException(InvalidArgumentException::class); $this->expectException(InvalidArgumentException::class);
$repository->insert($model); $repository->insert($model);
} }
@@ -118,10 +115,7 @@ class WorkingHoursRepositoryTest extends Unit
public function testDeleteWithInvalidModel(): void public function testDeleteWithInvalidModel(): void
{ {
$repository = new WorkingHoursRepository($this->pdoObject); $repository = new WorkingHoursRepository($this->pdoObject);
$model = $this->make(stdClass::class, [ $model = $this->makeEmpty(ModelInterface::class);
'workingDay' => new DateTime(self::EXISTING_DATE),
'workingTime' => new DateInterval(self::EXISTING_INTERVAL),
]);
$this->expectException(InvalidArgumentException::class); $this->expectException(InvalidArgumentException::class);
$repository->delete($model); $repository->delete($model);
} }
@@ -164,11 +158,7 @@ class WorkingHoursRepositoryTest extends Unit
public function testUpdateWithInvalidModel(): void public function testUpdateWithInvalidModel(): void
{ {
$repository = new WorkingHoursRepository($this->pdoObject); $repository = new WorkingHoursRepository($this->pdoObject);
$model = $this->make(stdClass::class, [ $model = $this->makeEmpty(ModelInterface::class);
'workingDay' => new DateTime(self::EXISTING_DATE),
'workingTime' => new DateInterval(self::NEW_INTERVAL),
]);
$this->expectException(InvalidArgumentException::class); $this->expectException(InvalidArgumentException::class);
$repository->update($model); $repository->update($model);
} }