From d11070ffbbc736619dbd3babcb63ed387d13b1a4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Torsten=20L=C3=BCcke?= <privat@torsten-hettstedt.de>
Date: Tue, 6 Apr 2021 11:15:25 +0200
Subject: [PATCH] Ergebnis bei *PHPStan* verbessert.

---
 api/src/Controller/HelloWorldController.php    | 12 ++++++++++--
 .../WorkingHoursRepositoryTest.php             | 18 ++++--------------
 2 files changed, 14 insertions(+), 16 deletions(-)

diff --git a/api/src/Controller/HelloWorldController.php b/api/src/Controller/HelloWorldController.php
index 25cd199..cb18a9d 100644
--- a/api/src/Controller/HelloWorldController.php
+++ b/api/src/Controller/HelloWorldController.php
@@ -8,8 +8,16 @@ use Slim\Psr7\Request;
 
 class HelloWorldController
 {
-    /** @noinspection PhpUnusedParameterInspection */
-    public function read(Request $request, Response $response, $args): Response
+    /**
+     * @param Request  $request
+     * @param Response $response
+     * @param mixed[]  $args
+     *
+     * @return Response
+     *
+     * @noinspection PhpUnusedParameterInspection
+     */
+    public function read(Request $request, Response $response, array $args): Response
     {
         $payload = json_encode('Hallo World');
 
diff --git a/api/tests/unit/Repositories/WorkingHoursRepositoryTest.php b/api/tests/unit/Repositories/WorkingHoursRepositoryTest.php
index 7c6dd2e..0fc1a48 100644
--- a/api/tests/unit/Repositories/WorkingHoursRepositoryTest.php
+++ b/api/tests/unit/Repositories/WorkingHoursRepositoryTest.php
@@ -9,7 +9,7 @@ use Exception;
 use InvalidArgumentException;
 use PDO;
 use PDOStatement;
-use stdClass;
+use TorstenHettstedt\TimekeepingApi\Models\ModelInterface;
 use TorstenHettstedt\TimekeepingApi\Models\WorkingHours;
 use TorstenHettstedt\TimekeepingApi\Repositories\RepositoryModelAlreadyExists;
 use TorstenHettstedt\TimekeepingApi\Repositories\RepositoryRecordNotFoundException;
@@ -70,10 +70,7 @@ class WorkingHoursRepositoryTest extends Unit
     public function testInsertWithInvalidModel(): void
     {
         $repository = new WorkingHoursRepository($this->pdoObject);
-        $model = $this->make(stdClass::class, [
-            'workingDay'  => new DateTime(self::NEW_DATE),
-            'workingTime' => new DateInterval(self::NEW_INTERVAL),
-        ]);
+        $model = $this->makeEmpty(ModelInterface::class);
         $this->expectException(InvalidArgumentException::class);
         $repository->insert($model);
     }
@@ -118,10 +115,7 @@ class WorkingHoursRepositoryTest extends Unit
     public function testDeleteWithInvalidModel(): void
     {
         $repository = new WorkingHoursRepository($this->pdoObject);
-        $model = $this->make(stdClass::class, [
-            'workingDay'  => new DateTime(self::EXISTING_DATE),
-            'workingTime' => new DateInterval(self::EXISTING_INTERVAL),
-        ]);
+        $model = $this->makeEmpty(ModelInterface::class);
         $this->expectException(InvalidArgumentException::class);
         $repository->delete($model);
     }
@@ -164,11 +158,7 @@ class WorkingHoursRepositoryTest extends Unit
     public function testUpdateWithInvalidModel(): void
     {
         $repository = new WorkingHoursRepository($this->pdoObject);
-        $model = $this->make(stdClass::class, [
-            'workingDay'  => new DateTime(self::EXISTING_DATE),
-            'workingTime' => new DateInterval(self::NEW_INTERVAL),
-        ]);
-
+        $model = $this->makeEmpty(ModelInterface::class);
         $this->expectException(InvalidArgumentException::class);
         $repository->update($model);
     }