clean-code #4

Merged
TorstenHettstedt merged 9 commits from clean-code into master 2021-03-23 16:25:58 +01:00
4 changed files with 29 additions and 21 deletions
Showing only changes of commit 15b425aa22 - Show all commits
@@ -11,6 +11,9 @@ class ValidColorValuesProvider
const RGB = 'rgb';
const HSV = 'hsv';
/**
* @var array<string, array<string, float>[]>
*/
protected array $definitions = [
'weiß' => [
self::CMYK => [
@@ -302,6 +305,11 @@ class ValidColorValuesProvider
],
];
/**
* @param array<string> $order
*
* @return array<string, array<string, float>[]>
*/
public function getValidColorValues(array $order): array
{
$values = [];
@@ -16,7 +16,7 @@ class CyanMagentaYellowKeyTransformerTest extends Unit
protected CyanMagentaYellowKey $color;
/**
* @return float[][][]
* @return array<string, array<string, float>[]>
*/
public function validRgbValuesProvider(): array
{
@@ -27,7 +27,7 @@ class CyanMagentaYellowKeyTransformerTest extends Unit
}
/**
* @return float[][][]
* @return array<string, array<string, float>[]>
*/
public function validHsvValuesProvider(): array
{
@@ -38,8 +38,8 @@ class CyanMagentaYellowKeyTransformerTest extends Unit
}
/**
* @param array $cmyk
* @param array $rgb
* @param array<string, float> $cmyk
* @param array<string, float> $rgb
*
* @dataProvider validRgbValuesProvider
*
@@ -60,7 +60,7 @@ class CyanMagentaYellowKeyTransformerTest extends Unit
}
/**
* @param array $cmyk
* @param array<string, float> $cmyk
*
* @dataProvider validRgbValuesProvider
*
@@ -82,8 +82,8 @@ class CyanMagentaYellowKeyTransformerTest extends Unit
}
/**
* @param array $cmyk
* @param array $hsv
* @param array<string, float> $cmyk
* @param array<string, float> $hsv
*
* @throws Exception
*
@@ -16,7 +16,7 @@ class HueSaturationValueTransformerTest extends Unit
protected HueSaturationValue $color;
/**
* @return float[][][]
* @return array<string, array<string, float>[]>
*/
public function validCmykValuesProvider(): array
{
@@ -27,7 +27,7 @@ class HueSaturationValueTransformerTest extends Unit
}
/**
* @return float[][][]
* @return array<string, array<string, float>[]>
*/
public function validRgbValuesProvider(): array
{
@@ -38,8 +38,8 @@ class HueSaturationValueTransformerTest extends Unit
}
/**
* @param array $hsv
* @param array $rgb
* @param array<string, float> $hsv
* @param array<string, float> $rgb
*
* @dataProvider validRgbValuesProvider
*
@@ -60,8 +60,8 @@ class HueSaturationValueTransformerTest extends Unit
}
/**
* @param array $hsv
* @param array $cmyk
* @param array<string, float> $hsv
* @param array<string, float> $cmyk
*
* @throws Exception
* @dataProvider validCmykValuesProvider
@@ -83,7 +83,7 @@ class HueSaturationValueTransformerTest extends Unit
}
/**
* @param array $hsv
* @param array<string, float> $hsv
*
* @throws Exception
* @dataProvider validCmykValuesProvider
@@ -16,7 +16,7 @@ class RedGreenBlueTransformerTest extends Unit
protected RedGreenBlue $color;
/**
* @return float[][][]
* @return array<string, array<string, float>[]>
*/
public function validCmykValuesProvider(): array
{
@@ -27,7 +27,7 @@ class RedGreenBlueTransformerTest extends Unit
}
/**
* @return float[][][]
* @return array<string, array<string, float>[]>
*/
public function validHsvValuesProvider(): array
{
@@ -38,7 +38,7 @@ class RedGreenBlueTransformerTest extends Unit
}
/**
* @param array $rgb
* @param array<string, float> $rgb
*
* @dataProvider validCmykValuesProvider
*
@@ -59,8 +59,8 @@ class RedGreenBlueTransformerTest extends Unit
}
/**
* @param array $rgb
* @param array $cmyk
* @param array<string, float> $rgb
* @param array<string, float> $cmyk
*
* @throws Exception
* @dataProvider validCmykValuesProvider
@@ -82,8 +82,8 @@ class RedGreenBlueTransformerTest extends Unit
}
/**
* @param array $rgb
* @param array $hsv
* @param array<string, float> $rgb
* @param array<string, float> $hsv
*
* @throws Exception
* @dataProvider validHsvValuesProvider