16 Commits
Author SHA1 Message Date
TorstenHettstedt 05d46ec407 Merge pull request 'Die ausgegebene Reihenfolge ist von der Reihenfolge in der Datenbank unabhängig.' (#9) from bugfix/sortierung into master
Reviewed-on: #9
2021-04-13 13:02:09 +02:00
Torstem_JetBrain 7b48e7e9e2 Die ausgegebene Reihenfolge ist von der Reihenfolge in der Datenbank unabhängig. 2021-04-13 13:00:58 +02:00
TorstenHettstedt 343f12b605 Merge pull request 'bugfixes/cors-problem' (#7) from bugfixes/cors-problem into master
Reviewed-on: #7
2021-04-13 12:44:21 +02:00
Torstem_JetBrain 6203f98e93 Alle notwendigen Header werden mitgeliefert. 2021-04-13 12:43:31 +02:00
Torstem_JetBrain 87f3bb3f0e Es sollte auf die notwendigen Header geachtet werden (https://developer.mozilla.org/de/docs/Web/HTTP/CORS) 2021-04-13 12:34:25 +02:00
Torstem_JetBrain 8d00e0c104 zu viele Zeilen 2021-04-13 12:29:27 +02:00
Torstem_JetBrain 3fe73f3b10 Preflight- und CORS-Abfragen werden verarbeitet. 2021-04-12 18:47:48 +02:00
Torstem_JetBrain b5af0c5a54 Vorbereitung für Preflight- und CORS-Abfragen. 2021-04-12 18:46:37 +02:00
Torstem_JetBrain e29a6dcab9 Der Regex ist nun vollständig. 2021-04-12 18:45:16 +02:00
Torstem_JetBrain 8ee9666250 Die Tests wurden um die Preflight-Tests erweitert. 2021-04-12 18:26:57 +02:00
Torstem_JetBrain edcb80421b Der Browser sendet auch das Protokoll mit. 2021-04-12 18:26:12 +02:00
Torstem_JetBrain 16e05ce819 Die API-Tests wurden um eine Preflight-Überprüfung erweitert, um CORS-Probleme zu vermindern. 2021-04-12 15:56:35 +02:00
TorstenHettstedt 5c15580738 Merge pull request 'js-rest-aktionen' (#6) from js-rest-aktionen into master
Reviewed-on: #6
2021-04-12 14:11:31 +02:00
Torstem_JetBrain 0a5e40d7cb Es gibt ein Objekt 'Controller', dass die Funktionen für die Tasten-Aktionen sammelt.
Es gibt nun eine Initialisierung-Funktion.
Wenn eine Bearbeitung abgebrochen wird, wird nicht jedes mal die Liste neu geladen.
2021-04-12 14:11:00 +02:00
Torstem_JetBrain ae7491f002 Die Eintragungen wurden wo möglich mit den Defaultwerten gesetzt. Ging aber nur bei der Angabe der Zeit. 2021-04-12 12:29:00 +02:00
Torstem_JetBrain 8296a2a281 Die Test-Objekte sind nicht mehr notwendig. 2021-04-10 15:42:21 +02:00
16 changed files with 244 additions and 35 deletions
+4 -1
View File
@@ -2,4 +2,7 @@
DATABASES_HOST=psql.domain.tld DATABASES_HOST=psql.domain.tld
DATABASES_NAME=db DATABASES_NAME=db
DATABASES_USER=user DATABASES_USER=user
DATABASES_PASS=1234 DATABASES_PASS=1234
## CORS Einstellungen
CORS_ALLOW_ORIGIN_REGEX=/https?:\/\/localhost:\d+/
+10
View File
@@ -7,10 +7,12 @@ $dotenv->load();
use DI\Container; use DI\Container;
use Slim\Factory\AppFactory; use Slim\Factory\AppFactory;
use Slim\Routing\RouteCollectorProxy; use Slim\Routing\RouteCollectorProxy;
use TorstenHettstedt\TimekeepingApi\Controller\PreflightController;
use TorstenHettstedt\TimekeepingApi\Controller\WorkingHoursController; use TorstenHettstedt\TimekeepingApi\Controller\WorkingHoursController;
use TorstenHettstedt\TimekeepingApi\Controller\WorkingHoursViewController; use TorstenHettstedt\TimekeepingApi\Controller\WorkingHoursViewController;
use TorstenHettstedt\TimekeepingApi\Middleware\ErrorHandler; use TorstenHettstedt\TimekeepingApi\Middleware\ErrorHandler;
use TorstenHettstedt\TimekeepingApi\Middleware\JsonBodyParserMiddleware; use TorstenHettstedt\TimekeepingApi\Middleware\JsonBodyParserMiddleware;
use TorstenHettstedt\TimekeepingApi\Middleware\OriginAccessControlHandler;
$container = new Container(); $container = new Container();
@@ -22,17 +24,25 @@ $container->set('databases', function () {
AppFactory::setContainer($container); AppFactory::setContainer($container);
$app = AppFactory::create(); $app = AppFactory::create();
$app->add(new JsonBodyParserMiddleware()); $app->add(new JsonBodyParserMiddleware());
$app->addBodyParsingMiddleware();
$app->add(new OriginAccessControlHandler());
$app->addRoutingMiddleware();
$app->group('/views/working-hours', function (RouteCollectorProxy $group) { $app->group('/views/working-hours', function (RouteCollectorProxy $group) {
$group->options('/weekly', PreflightController::class . ':preflight');
$group->get('/weekly', WorkingHoursViewController::class . ':browseWeekly'); $group->get('/weekly', WorkingHoursViewController::class . ':browseWeekly');
$group->options('/monthly', PreflightController::class . ':preflight');
$group->get('/monthly', WorkingHoursViewController::class . ':browseMonthly'); $group->get('/monthly', WorkingHoursViewController::class . ':browseMonthly');
$group->options('/yearly', PreflightController::class . ':preflight');
$group->get('/yearly', WorkingHoursViewController::class . ':browseYearly'); $group->get('/yearly', WorkingHoursViewController::class . ':browseYearly');
}); });
$app->group('/working-hours', function (RouteCollectorProxy $group) { $app->group('/working-hours', function (RouteCollectorProxy $group) {
$group->options('', PreflightController::class . ':preflight');
$group->get('', WorkingHoursController::class . ':browse'); $group->get('', WorkingHoursController::class . ':browse');
$group->post('', WorkingHoursController::class . ':creat'); $group->post('', WorkingHoursController::class . ':creat');
$group->group('/{id:\d\d\d\d-\d\d-\d\d}', function (RouteCollectorProxy $group) { $group->group('/{id:\d\d\d\d-\d\d-\d\d}', function (RouteCollectorProxy $group) {
$group->options('', PreflightController::class . ':preflight');
$group->get('', WorkingHoursController::class . ':read'); $group->get('', WorkingHoursController::class . ':read');
$group->put('', WorkingHoursController::class . ':update'); $group->put('', WorkingHoursController::class . ':update');
}); });
@@ -0,0 +1,18 @@
<?php
namespace TorstenHettstedt\TimekeepingApi\Controller;
use Psr\Http\Message\ResponseInterface;
use Slim\Psr7\Request;
use Slim\Psr7\Response;
use TorstenHettstedt\TimekeepingApi\Middleware\OriginAccessControlHandler;
class PreflightController
{
public function preflight(Request $request, Response $response): ResponseInterface
{
return (new OriginAccessControlHandler())->originAccessControl($request, $response);
}
}
+3 -1
View File
@@ -84,7 +84,9 @@ class ErrorHandler
json_encode($payload, JSON_UNESCAPED_UNICODE) json_encode($payload, JSON_UNESCAPED_UNICODE)
); );
return $response; $originAccessControlHandler = new OriginAccessControlHandler();
return $originAccessControlHandler->originAccessControl($request, $response);
} }
} }
@@ -0,0 +1,58 @@
<?php
namespace TorstenHettstedt\TimekeepingApi\Middleware;
use Psr\Http\Message\ResponseInterface as Response;
use Psr\Http\Message\ServerRequestInterface as Request;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface as RequestHandler;
use Slim\Routing\RouteContext;
class OriginAccessControlHandler implements MiddlewareInterface
{
/**
* Process an incoming server request.
*
* Processes an incoming server request in order to produce a response.
* If unable to produce the response itself, it may delegate to the provided
* request handler to do so.
*/
public function process(Request $request, RequestHandler $handler): Response
{
$response = $handler->handle($request);
return $this->originAccessControl($request, $response);
}
public function originAccessControl(Request $request, Response $response): Response
{
$routeContext = RouteContext::fromRequest($request);
$routingResults = $routeContext->getRoutingResults();
$methods = $routingResults->getAllowedMethods();
$requestHeaders = $request->getHeaderLine('Access-Control-Request-Headers');
if ($this->testRoute($request)) {
// Stunden Minuten Sekunden
$accessControlMaxAge = 24 * 60 * 60;
$response = $response->withHeader('Access-Control-Allow-Origin', $this->buildOrigin($request));
$response = $response->withHeader('Access-Control-Allow-Methods', implode(',', $methods));
$response = $response->withHeader('Access-Control-Allow-Headers', $requestHeaders);
$response = $response->withHeader('Access-Control-Max-Age', (string)$accessControlMaxAge);
}
return $response;
}
protected function testRoute(Request $request): bool
{
$corsAllowOriginRegex = $_ENV['CORS_ALLOW_ORIGIN_REGEX'] ?? '/https?:\/\/.*:.*/';
return preg_match($corsAllowOriginRegex, $this->buildOrigin($request));
}
protected function buildOrigin(Request $request): string
{
return $request->getHeaderLine('Origin') ?? '';
}
}
@@ -44,7 +44,7 @@ class WorkingHoursRepository implements RepositoryReaderInterface, RepositoryWri
public function findAll(): array public function findAll(): array
{ {
$models = []; $models = [];
$stmt = $this->database->prepare('select "Datum" as "workingDay", "Arbeitszeit" as "workingTime" from public."Arbeitszeiten"'); $stmt = $this->database->prepare('select "Datum" as "workingDay", "Arbeitszeit" as "workingTime" from public."Arbeitszeiten" order by "Datum"');
$stmt->execute(); $stmt->execute();
while ($row = $stmt->fetch()) { while ($row = $stmt->fetch()) {
$model = new WorkingHours(); $model = new WorkingHours();
+2
View File
@@ -32,4 +32,6 @@ class Api extends Module
"message" => "string", "message" => "string",
"path" => "string", "path" => "string",
]; ];
const TEST_ORIGIN = 'http://localhost:1234';
} }
@@ -8,13 +8,27 @@ use Helper\Api;
class BrowseWorkingHoursMonthlyCest class BrowseWorkingHoursMonthlyCest
{ {
public static function preflight(ApiTester $I): void
{
$I->haveHttpHeader('Origin', Api::TEST_ORIGIN);
$I->haveHttpHeader('Access-Control-Request-Method', 'GET');
$I->sendOptions('/views/working-hours/monthly');
$I->seeResponseCodeIs(HttpCode::OK);
$I->seeHttpHeader('Access-Control-Allow-Origin', Api::TEST_ORIGIN);
$I->seeHttpHeader('Access-Control-Allow-Methods');
$I->seeHttpHeader('Access-Control-Allow-Headers');
$I->seeHttpHeader('Access-Control-Max-Age');
}
/** /**
* @param ApiTester $I * @param ApiTester $I
*/ */
public function browseWorkingHoursView(ApiTester $I): void public function browseWorkingHoursView(ApiTester $I): void
{ {
$I->haveHttpHeader('Origin', Api::TEST_ORIGIN);
$I->sendGet('/views/working-hours/monthly'); $I->sendGet('/views/working-hours/monthly');
$I->seeResponseCodeIs(HttpCode::OK); $I->seeResponseCodeIs(HttpCode::OK);
$I->canSeeHttpHeader('Access-Control-Allow-Origin', Api::TEST_ORIGIN);
$I->seeResponseIsJson(); $I->seeResponseIsJson();
$I->seeResponseMatchesJsonType(Api::WORKING_HOURS_VIEW_JSON_FORMAT); $I->seeResponseMatchesJsonType(Api::WORKING_HOURS_VIEW_JSON_FORMAT);
} }
@@ -8,13 +8,27 @@ use Helper\Api;
class BrowseWorkingHoursWeeklyCest class BrowseWorkingHoursWeeklyCest
{ {
public static function preflight(ApiTester $I): void
{
$I->haveHttpHeader('Origin', Api::TEST_ORIGIN);
$I->haveHttpHeader('Access-Control-Request-Method', 'GET');
$I->sendOptions('/views/working-hours/weekly');
$I->seeResponseCodeIs(HttpCode::OK);
$I->seeHttpHeader('Access-Control-Allow-Origin', Api::TEST_ORIGIN);
$I->seeHttpHeader('Access-Control-Allow-Methods');
$I->seeHttpHeader('Access-Control-Allow-Headers');
$I->seeHttpHeader('Access-Control-Max-Age');
}
/** /**
* @param ApiTester $I * @param ApiTester $I
*/ */
public function browseWorkingHoursView(ApiTester $I): void public function browseWorkingHoursView(ApiTester $I): void
{ {
$I->haveHttpHeader('Origin', Api::TEST_ORIGIN);
$I->sendGet('/views/working-hours/weekly'); $I->sendGet('/views/working-hours/weekly');
$I->seeResponseCodeIs(HttpCode::OK); $I->seeResponseCodeIs(HttpCode::OK);
$I->canSeeHttpHeader('Access-Control-Allow-Origin', Api::TEST_ORIGIN);
$I->seeResponseIsJson(); $I->seeResponseIsJson();
$I->seeResponseMatchesJsonType(Api::WORKING_HOURS_VIEW_JSON_FORMAT); $I->seeResponseMatchesJsonType(Api::WORKING_HOURS_VIEW_JSON_FORMAT);
} }
@@ -8,13 +8,27 @@ use Helper\Api;
class BrowseWorkingHoursYearlyCest class BrowseWorkingHoursYearlyCest
{ {
public static function preflight(ApiTester $I): void
{
$I->haveHttpHeader('Origin', Api::TEST_ORIGIN);
$I->haveHttpHeader('Access-Control-Request-Method', 'GET');
$I->sendOptions('/views/working-hours/yearly');
$I->seeResponseCodeIs(HttpCode::OK);
$I->seeHttpHeader('Access-Control-Allow-Origin', Api::TEST_ORIGIN);
$I->seeHttpHeader('Access-Control-Allow-Methods');
$I->seeHttpHeader('Access-Control-Allow-Headers');
$I->seeHttpHeader('Access-Control-Max-Age');
}
/** /**
* @param ApiTester $I * @param ApiTester $I
*/ */
public function browseWorkingHoursView(ApiTester $I): void public function browseWorkingHoursView(ApiTester $I): void
{ {
$I->haveHttpHeader('Origin', Api::TEST_ORIGIN);
$I->sendGet('/views/working-hours/yearly'); $I->sendGet('/views/working-hours/yearly');
$I->seeResponseCodeIs(HttpCode::OK); $I->seeResponseCodeIs(HttpCode::OK);
$I->canSeeHttpHeader('Access-Control-Allow-Origin', Api::TEST_ORIGIN);
$I->seeResponseIsJson(); $I->seeResponseIsJson();
$I->seeResponseMatchesJsonType(Api::WORKING_HOURS_VIEW_JSON_FORMAT); $I->seeResponseMatchesJsonType(Api::WORKING_HOURS_VIEW_JSON_FORMAT);
} }
@@ -8,13 +8,27 @@ use Helper\Api;
class BrowseWorkingHoursCest class BrowseWorkingHoursCest
{ {
public static function preflight(ApiTester $I): void
{
$I->haveHttpHeader('Origin', Api::TEST_ORIGIN);
$I->haveHttpHeader('Access-Control-Request-Method', 'GET');
$I->sendOptions('/working-hours');
$I->seeResponseCodeIs(HttpCode::OK);
$I->seeHttpHeader('Access-Control-Allow-Origin', Api::TEST_ORIGIN);
$I->seeHttpHeader('Access-Control-Allow-Methods');
$I->seeHttpHeader('Access-Control-Allow-Headers');
$I->seeHttpHeader('Access-Control-Max-Age');
}
/** /**
* @param ApiTester $I * @param ApiTester $I
*/ */
public function browseWorkingHours(ApiTester $I): void public function browseWorkingHours(ApiTester $I): void
{ {
$I->haveHttpHeader('Origin', Api::TEST_ORIGIN);
$I->sendGet('/working-hours'); $I->sendGet('/working-hours');
$I->seeResponseCodeIs(HttpCode::OK); $I->seeResponseCodeIs(HttpCode::OK);
$I->canSeeHttpHeader('Access-Control-Allow-Origin', Api::TEST_ORIGIN);
$I->seeResponseIsJson(); $I->seeResponseIsJson();
$I->seeResponseMatchesJsonType(Api::WORKING_HOURS_JSON_FORMAT); $I->seeResponseMatchesJsonType(Api::WORKING_HOURS_JSON_FORMAT);
} }
@@ -8,15 +8,29 @@ use Helper\Api;
class CreateWorkingHoursCest class CreateWorkingHoursCest
{ {
public static function preflight(ApiTester $I): void
{
$I->haveHttpHeader('Origin', Api::TEST_ORIGIN);
$I->haveHttpHeader('Access-Control-Request-Method', 'POST');
$I->sendOptions('/working-hours');
$I->seeResponseCodeIs(HttpCode::OK);
$I->seeHttpHeader('Access-Control-Allow-Origin', Api::TEST_ORIGIN);
$I->seeHttpHeader('Access-Control-Allow-Methods');
$I->seeHttpHeader('Access-Control-Allow-Headers');
$I->seeHttpHeader('Access-Control-Max-Age');
}
public function createWorkingHoursWithNewValidRecord(ApiTester $I): void public function createWorkingHoursWithNewValidRecord(ApiTester $I): void
{ {
$I->haveHttpHeader('accept', 'application/json'); $I->haveHttpHeader('accept', 'application/json');
$I->haveHttpHeader('content-type', 'application/json'); $I->haveHttpHeader('content-type', 'application/json');
$I->haveHttpHeader('Origin', Api::TEST_ORIGIN);
$I->sendPost('/working-hours', [ $I->sendPost('/working-hours', [
'workingDay' => '2020-04-01', 'workingDay' => '2020-04-01',
'workingTime' => '08:00:00', 'workingTime' => '08:00:00',
]); ]);
$I->seeResponseCodeIs(HttpCode::CREATED); $I->seeResponseCodeIs(HttpCode::CREATED);
$I->canSeeHttpHeader('Access-Control-Allow-Origin', Api::TEST_ORIGIN);
$I->seeResponseIsJson(); $I->seeResponseIsJson();
$I->seeResponseMatchesJsonType(Api::WORKING_HOURS_JSON_FORMAT); $I->seeResponseMatchesJsonType(Api::WORKING_HOURS_JSON_FORMAT);
} }
@@ -26,11 +40,13 @@ class CreateWorkingHoursCest
{ {
$I->haveHttpHeader('accept', 'application/json'); $I->haveHttpHeader('accept', 'application/json');
$I->haveHttpHeader('content-type', 'application/json'); $I->haveHttpHeader('content-type', 'application/json');
$I->haveHttpHeader('Origin', Api::TEST_ORIGIN);
$I->sendPost('/working-hours', [ $I->sendPost('/working-hours', [
'workingDay' => '2020-04-01', 'workingDay' => '2020-04-01',
'workingTime' => 8.0, 'workingTime' => 8.0,
]); ]);
$I->seeResponseCodeIs(HttpCode::BAD_REQUEST); $I->seeResponseCodeIs(HttpCode::BAD_REQUEST);
$I->canSeeHttpHeader('Access-Control-Allow-Origin', Api::TEST_ORIGIN);
$I->seeResponseIsJson(); $I->seeResponseIsJson();
$I->seeResponseMatchesJsonType(Api::ERROR_JSON_FORMAT); $I->seeResponseMatchesJsonType(Api::ERROR_JSON_FORMAT);
} }
@@ -40,11 +56,13 @@ class CreateWorkingHoursCest
{ {
$I->haveHttpHeader('accept', 'application/json'); $I->haveHttpHeader('accept', 'application/json');
$I->haveHttpHeader('content-type', 'application/json'); $I->haveHttpHeader('content-type', 'application/json');
$I->haveHttpHeader('Origin', Api::TEST_ORIGIN);
$I->sendPost('/working-hours', [ $I->sendPost('/working-hours', [
'workingDay' => '2020-01-15', 'workingDay' => '2020-01-15',
'workingTime' => '08:00:00', 'workingTime' => '08:00:00',
]); ]);
$I->seeResponseCodeIs(HttpCode::CONFLICT); $I->seeResponseCodeIs(HttpCode::CONFLICT);
$I->canSeeHttpHeader('Access-Control-Allow-Origin', Api::TEST_ORIGIN);
$I->seeResponseIsJson(); $I->seeResponseIsJson();
$I->seeResponseMatchesJsonType(Api::ERROR_JSON_FORMAT); $I->seeResponseMatchesJsonType(Api::ERROR_JSON_FORMAT);
} }
@@ -8,18 +8,34 @@ use Helper\Api;
class ReadWorkingHoursCest class ReadWorkingHoursCest
{ {
public static function preflight(ApiTester $I): void
{
$I->haveHttpHeader('Origin', Api::TEST_ORIGIN);
$I->haveHttpHeader('Access-Control-Request-Method', 'GET');
$I->sendOptions('/working-hours/2020-04-15');
$I->seeResponseCodeIs(HttpCode::OK);
$I->seeHttpHeader('Access-Control-Allow-Origin', Api::TEST_ORIGIN);
$I->seeHttpHeader('Access-Control-Allow-Methods');
$I->seeHttpHeader('Access-Control-Allow-Headers');
$I->seeHttpHeader('Access-Control-Max-Age');
}
public function readExistingWorkingHours(ApiTester $I): void public function readExistingWorkingHours(ApiTester $I): void
{ {
$I->haveHttpHeader('Origin', Api::TEST_ORIGIN);
$I->sendGet('/working-hours/2020-01-15'); $I->sendGet('/working-hours/2020-01-15');
$I->seeResponseCodeIs(HttpCode::OK); $I->seeResponseCodeIs(HttpCode::OK);
$I->canSeeHttpHeader('Access-Control-Allow-Origin', Api::TEST_ORIGIN);
$I->seeResponseIsJson(); $I->seeResponseIsJson();
$I->seeResponseMatchesJsonType(Api::WORKING_HOURS_JSON_FORMAT); $I->seeResponseMatchesJsonType(Api::WORKING_HOURS_JSON_FORMAT);
} }
public function readNotExistingWorkingHours(ApiTester $I): void public function readNotExistingWorkingHours(ApiTester $I): void
{ {
$I->haveHttpHeader('Origin', Api::TEST_ORIGIN);
$I->sendGet('/working-hours/2020-04-15'); $I->sendGet('/working-hours/2020-04-15');
$I->seeResponseCodeIs(HttpCode::NOT_FOUND); $I->seeResponseCodeIs(HttpCode::NOT_FOUND);
$I->canSeeHttpHeader('Access-Control-Allow-Origin', Api::TEST_ORIGIN);
$I->seeResponseIsJson(); $I->seeResponseIsJson();
$I->seeResponseMatchesJsonType(Api::ERROR_JSON_FORMAT); $I->seeResponseMatchesJsonType(Api::ERROR_JSON_FORMAT);
} }
@@ -8,15 +8,29 @@ use Helper\Api;
class UpdateWorkingHoursCest class UpdateWorkingHoursCest
{ {
public static function preflight(ApiTester $I): void
{
$I->haveHttpHeader('Origin', Api::TEST_ORIGIN);
$I->haveHttpHeader('Access-Control-Request-Method', 'PUT');
$I->sendOptions('/working-hours/2020-01-15');
$I->seeResponseCodeIs(HttpCode::OK);
$I->seeHttpHeader('Access-Control-Allow-Origin', Api::TEST_ORIGIN);
$I->seeHttpHeader('Access-Control-Allow-Methods');
$I->seeHttpHeader('Access-Control-Allow-Headers');
$I->seeHttpHeader('Access-Control-Max-Age');
}
public function updateWorkingHoursWithExistingValidRecord(ApiTester $I): void public function updateWorkingHoursWithExistingValidRecord(ApiTester $I): void
{ {
$I->haveHttpHeader('accept', 'application/json'); $I->haveHttpHeader('accept', 'application/json');
$I->haveHttpHeader('content-type', 'application/json'); $I->haveHttpHeader('content-type', 'application/json');
$I->haveHttpHeader('Origin', Api::TEST_ORIGIN);
$I->sendPut('/working-hours/2020-01-15', [ $I->sendPut('/working-hours/2020-01-15', [
'workingDay' => '2020-01-15', 'workingDay' => '2020-01-15',
'workingTime' => '10:00:00', 'workingTime' => '10:00:00',
]); ]);
$I->seeResponseCodeIs(HttpCode::OK); $I->seeResponseCodeIs(HttpCode::OK);
$I->canSeeHttpHeader('Access-Control-Allow-Origin', Api::TEST_ORIGIN);
$I->seeResponseIsJson(); $I->seeResponseIsJson();
$I->seeResponseMatchesJsonType(Api::WORKING_HOURS_JSON_FORMAT); $I->seeResponseMatchesJsonType(Api::WORKING_HOURS_JSON_FORMAT);
} }
@@ -25,11 +39,13 @@ class UpdateWorkingHoursCest
{ {
$I->haveHttpHeader('accept', 'application/json'); $I->haveHttpHeader('accept', 'application/json');
$I->haveHttpHeader('content-type', 'application/json'); $I->haveHttpHeader('content-type', 'application/json');
$I->haveHttpHeader('Origin', Api::TEST_ORIGIN);
$I->sendPut('/working-hours/2020-04-15', [ $I->sendPut('/working-hours/2020-04-15', [
'workingDay' => '2020-04-15', 'workingDay' => '2020-04-15',
'workingTime' => '10:00:00', 'workingTime' => '10:00:00',
]); ]);
$I->seeResponseCodeIs(HttpCode::NOT_FOUND); $I->seeResponseCodeIs(HttpCode::NOT_FOUND);
$I->canSeeHttpHeader('Access-Control-Allow-Origin', Api::TEST_ORIGIN);
$I->seeResponseIsJson(); $I->seeResponseIsJson();
$I->seeResponseMatchesJsonType(Api::ERROR_JSON_FORMAT); $I->seeResponseMatchesJsonType(Api::ERROR_JSON_FORMAT);
} }
@@ -38,11 +54,13 @@ class UpdateWorkingHoursCest
{ {
$I->haveHttpHeader('accept', 'application/json'); $I->haveHttpHeader('accept', 'application/json');
$I->haveHttpHeader('content-type', 'application/json'); $I->haveHttpHeader('content-type', 'application/json');
$I->haveHttpHeader('Origin', Api::TEST_ORIGIN);
$I->sendPut('/working-hours/2020-01-15', [ $I->sendPut('/working-hours/2020-01-15', [
'workingDay' => '2020-01-15', 'workingDay' => '2020-01-15',
'workingTime' => 8.0, 'workingTime' => 8.0,
]); ]);
$I->seeResponseCodeIs(HttpCode::BAD_REQUEST); $I->seeResponseCodeIs(HttpCode::BAD_REQUEST);
$I->canSeeHttpHeader('Access-Control-Allow-Origin', Api::TEST_ORIGIN);
$I->seeResponseIsJson(); $I->seeResponseIsJson();
$I->seeResponseMatchesJsonType(Api::ERROR_JSON_FORMAT); $I->seeResponseMatchesJsonType(Api::ERROR_JSON_FORMAT);
} }
+1 -11
View File
@@ -45,22 +45,12 @@
addEventListener('pushstate', track); addEventListener('pushstate', track);
addEventListener('popstate', track); addEventListener('popstate', track);
let r = {
"workingDay": "2020-01-15",
"workingTime": "09:00:00"
};
let records = {
"title" : "Einträge",
"records" : [r, r]
};
const router = Navaid('/') const router = Navaid('/')
.on('/', () => run(import('../routes/Home.svelte'))) .on('/', () => run(import('../routes/Home.svelte')))
.on('/views/weekly', () => run(import('../routes/WeeklyViews.svelte'))) .on('/views/weekly', () => run(import('../routes/WeeklyViews.svelte')))
.on('/views/monthly', () => run(import('../routes/MonthlyViews.svelte'))) .on('/views/monthly', () => run(import('../routes/MonthlyViews.svelte')))
.on('/views/yearly', () => run(import('../routes/YearlyViews.svelte'))) .on('/views/yearly', () => run(import('../routes/YearlyViews.svelte')))
.on('/working-hours', () => run(import('../routes/WorkingHours.svelte'), records)) .on('/working-hours', () => run(import('../routes/WorkingHours.svelte')))
.listen(); .listen();
onDestroy(router.unlisten); onDestroy(router.unlisten);
+39 -21
View File
@@ -24,7 +24,7 @@
return res.json(); return res.json();
}) })
.then(data => { .then(data => {
activeRecord = null; Controller.cancelActiveRecord();
params.records = data; params.records = data;
params.isLoading = false; params.isLoading = false;
}) })
@@ -45,7 +45,7 @@
.then(data => { .then(data => {
activeRecord = data; activeRecord = data;
if (date === null) { if (date === null) {
Records.browse(); Controller.listRecords();
} }
}) })
.catch(err => { .catch(err => {
@@ -73,8 +73,7 @@
} }
}) })
.then(() => { .then(() => {
newRecord = false; Controller.listRecords();
Records.browse();
}) })
.catch(err => { .catch(err => {
console.log(err); console.log(err);
@@ -101,14 +100,39 @@
} }
}) })
.then(() => { .then(() => {
Records.browse(); Controller.listRecords();
}) })
.catch(err => { .catch(err => {
console.log(err); console.log(err);
}); });
} }
}; };
Records.browse(); const Controller = {
'listRecords': () => {
Controller.cancelActiveRecord();
Records.browse();
},
'newRecord': () => {
activeRecord = {workingTime: '00:00:00'};
newRecord = true;
},
'saveRecord': () => {
if (newRecord === true) {
Records.add(activeRecord);
} else {
Records.update(activeRecord.workingDay, activeRecord);
}
},
'selectActiveRecord': record => Records.read(record.workingDay),
'cancelActiveRecord': () => {
activeRecord = null;
newRecord = false;
}
};
const initSite = () => {
Controller.listRecords()
};
initSite()
</script> </script>
<svelte:head> <svelte:head>
@@ -127,7 +151,7 @@
<!--suppress HtmlUnknownTarget --> <!--suppress HtmlUnknownTarget -->
<form action="/working-hours"> <form action="/working-hours">
<fieldset> <fieldset>
<button on:click={() => {activeRecord = {}; newRecord = true}}>Neuer Eintrag <button on:click={Controller.newRecord}>Neuer Eintrag
<IconifyIcon icon={documentIcon}/> <IconifyIcon icon={documentIcon}/>
</button> </button>
</fieldset> </fieldset>
@@ -146,7 +170,7 @@
<td>{record.workingDay}</td> <td>{record.workingDay}</td>
<td>{record.workingTime}</td> <td>{record.workingTime}</td>
<td> <td>
<button on:click={() => Records.read(record.workingDay)}>Bearbeiten <button on:click={() => Controller.selectActiveRecord(record)}>Bearbeiten
<IconifyIcon icon={wrenchIcon}/> <IconifyIcon icon={wrenchIcon}/>
</button> </button>
</td> </td>
@@ -168,26 +192,20 @@
<fieldset name="record-data"> <fieldset name="record-data">
<div> <div>
<label for="workingDay">Arbeitstag</label> <label for="workingDay">Arbeitstag</label>
<input bind:value={activeRecord.workingDay} placeholder="Arbeitstag" type="date" <input bind:value={activeRecord.workingDay} type="date"
id="workingDay"> id="workingDay" required pattern="\d{4}-\d{2}-\d{2}">
</div> </div>
<div> <div>
<label for="workingTime">Arbeitszeit</label> <label for="workingTime">Arbeitszeit</label>
<input bind:value={activeRecord.workingTime} placeholder="Arbeitszeit" type="time" <input bind:value={activeRecord.workingTime} placeholder="Arbeitszeit" type="time"
id="workingTime"> id="workingTime" required pattern="[0-5]\d:[0-5]\d:[0-5]\d">
</div> </div>
</fieldset> </fieldset>
<fieldset name="buttons"> <fieldset name="buttons">
{#if newRecord === true} <button on:click={Controller.saveRecord}>Übernehmen
<button on:click={() => Records.add(activeRecord)}>Übernehmen <IconifyIcon icon={checkIcon} color="green"/>
<IconifyIcon icon={checkIcon} color="green"/> </button>
</button> <button on:click={Controller.cancelActiveRecord}>Abbrechen
{:else}
<button on:click={() => Records.update(activeRecord.workingDay, activeRecord)}>Übernehmen
<IconifyIcon icon={checkIcon} color="green"/>
</button>
{/if}
<button on:click={() => Records.read(null)}>Abbrechen
<IconifyIcon icon={xIcon}/> <IconifyIcon icon={xIcon}/>
</button> </button>
</fieldset> </fieldset>