From d52a9d77ab85cac9be2e562726b408bd43d19be2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Torsten=20L=C3=BCcke?= <arbeit@torsten-hettstedt.de>
Date: Mon, 16 Jun 2025 15:14:31 +0200
Subject: [PATCH] Korrigiere PHP-Hinweise

---
 api/src/Models/WorkingHoursView.php           | 23 ++++++-------------
 .../WorkingHoursMonthlyViewRepository.php     |  4 ++--
 .../Repositories/WorkingHoursRepository.php   | 13 +++++++----
 .../WorkingHoursWeeklyViewRepository.php      |  4 ++--
 .../WorkingHoursYearlyViewRepository.php      |  4 ++--
 api/tests/api.suite.dist.yml                  |  2 +-
 .../Controller/WorkingHoursControllerTest.php |  6 -----
 7 files changed, 23 insertions(+), 33 deletions(-)

diff --git a/api/src/Models/WorkingHoursView.php b/api/src/Models/WorkingHoursView.php
index bdeef5c..77bf15d 100644
--- a/api/src/Models/WorkingHoursView.php
+++ b/api/src/Models/WorkingHoursView.php
@@ -10,24 +10,14 @@ use JetBrains\PhpStorm\ArrayShape;
 
 class WorkingHoursView implements ModelInterface
 {
-    protected DateTimeInterface     $period;
-    protected PeriodDesignationEnum $periodDesignation;
-    protected int                   $workingDays;
-    protected DateInterval          $totalHours;
-    protected DateInterval          $overtime;
 
     public function __construct(
-        DateTimeInterface $period,
-        PeriodDesignationEnum $periodDesignation,
-        int $workingDays,
-        DateInterval $totalHours,
-        DateInterval $overtime
+        protected DateTimeInterface $period,
+        protected PeriodDesignationEnum $periodDesignation,
+        protected int $workingDays,
+        protected DateInterval $totalHours,
+        protected DateInterval $overtime
     ) {
-        $this->period = $period;
-        $this->periodDesignation = $periodDesignation;
-        $this->workingDays = $workingDays;
-        $this->totalHours = $totalHours;
-        $this->overtime = $overtime;
     }
 
     public function getPeriod(): DateTimeInterface
@@ -66,7 +56,8 @@ class WorkingHoursView implements ModelInterface
         'totalHours'        => "string",
         'workingDays'       => "int",
         'overtime'          => "string"
-    ])] public function jsonSerialize(): array
+    ])]
+    public function jsonSerialize(): array
     {
         $formatOvertime = (($this->getOvertime()->invert === 1) ? '-' : '') . '%H:%I:%S';
         return [
diff --git a/api/src/Repositories/WorkingHoursMonthlyViewRepository.php b/api/src/Repositories/WorkingHoursMonthlyViewRepository.php
index a307076..f20e1eb 100644
--- a/api/src/Repositories/WorkingHoursMonthlyViewRepository.php
+++ b/api/src/Repositories/WorkingHoursMonthlyViewRepository.php
@@ -12,7 +12,7 @@ use TorstenHettstedt\TimekeepingApi\Models\PeriodDesignationEnum;
 class WorkingHoursMonthlyViewRepository extends AbstractWorkingHoursViewRepository
 {
 
-    protected const SQL_SELECT = <<<SQL
+    protected const string SQL_SELECT = <<<SQL
         select
             "Monat" as "period",
             "Gesamtarbeitszeit" as "totalHours",
@@ -20,7 +20,7 @@ class WorkingHoursMonthlyViewRepository extends AbstractWorkingHoursViewReposito
             "Überstunden" as "overtime"
         from "Arbeitszeiten - Monat"
 SQL;
-    protected const SQL_WHERE  = ' where "Monat" = ?';
+    protected const string SQL_WHERE  = ' where "Monat" = ?';
 
     public function __construct(PDO $database)
     {
diff --git a/api/src/Repositories/WorkingHoursRepository.php b/api/src/Repositories/WorkingHoursRepository.php
index 3434753..667036f 100644
--- a/api/src/Repositories/WorkingHoursRepository.php
+++ b/api/src/Repositories/WorkingHoursRepository.php
@@ -20,6 +20,13 @@ use TorstenHettstedt\TimekeepingApi\Models\WorkingHours;
  */
 class WorkingHoursRepository implements RepositoryReaderInterface, RepositoryWriterInterface
 {
+    protected const string SQL_SELECT = <<<'SQL'
+select
+    "Datum" as "workingDay",
+    "Arbeitszeit" as "workingTime"
+from public."Arbeitszeiten"
+SQL;
+
 
     public function __construct(protected PDO $database)
     {
@@ -88,7 +95,7 @@ class WorkingHoursRepository implements RepositoryReaderInterface, RepositoryWri
 
     protected function buildFindFilteredStatement(?string $start, ?string $end): ?PDOStatement
     {
-        $query = 'select "Datum" as "workingDay", "Arbeitszeit" as "workingTime" from public."Arbeitszeiten" ';
+        $query = static::SQL_SELECT . ' ';
         $query .= $this->buildFilterString($start, $end);
         $query .= 'order by "Datum"';
         $stmt = $this->database->prepare($query);
@@ -113,9 +120,7 @@ class WorkingHoursRepository implements RepositoryReaderInterface, RepositoryWri
      */
     public function findByKey(mixed $primary_key): WorkingHours
     {
-        $stmt = $this->database->prepare(
-            'select "Datum" as "workingDay", "Arbeitszeit" as "workingTime" from public."Arbeitszeiten" where "Datum" = ?'
-        );
+        $stmt = $this->database->prepare(static::SQL_SELECT  . ' where "Datum" = ?');
         $stmt->bindParam(1, $primary_key);
         $stmt->execute();
         $row = $stmt->fetch();
diff --git a/api/src/Repositories/WorkingHoursWeeklyViewRepository.php b/api/src/Repositories/WorkingHoursWeeklyViewRepository.php
index e0f383b..a0627fc 100644
--- a/api/src/Repositories/WorkingHoursWeeklyViewRepository.php
+++ b/api/src/Repositories/WorkingHoursWeeklyViewRepository.php
@@ -11,7 +11,7 @@ use TorstenHettstedt\TimekeepingApi\Models\PeriodDesignationEnum;
 class WorkingHoursWeeklyViewRepository extends AbstractWorkingHoursViewRepository
 {
 
-    protected const SQL_SELECT = <<<SQL
+    protected const string SQL_SELECT = <<<SQL
         select
             "Woche" as "period",
             "Gesamtarbeitszeit" as "totalHours",
@@ -19,7 +19,7 @@ class WorkingHoursWeeklyViewRepository extends AbstractWorkingHoursViewRepositor
             "Überstunden" as "overtime"
         from "Arbeitszeiten - Woche"
 SQL;
-    protected const SQL_WHERE  = ' where "Woche" = ?';
+    protected const string SQL_WHERE  = ' where "Woche" = ?';
 
     public function __construct(PDO $database)
     {
diff --git a/api/src/Repositories/WorkingHoursYearlyViewRepository.php b/api/src/Repositories/WorkingHoursYearlyViewRepository.php
index 522e37b..7a01e94 100644
--- a/api/src/Repositories/WorkingHoursYearlyViewRepository.php
+++ b/api/src/Repositories/WorkingHoursYearlyViewRepository.php
@@ -11,7 +11,7 @@ use TorstenHettstedt\TimekeepingApi\Models\PeriodDesignationEnum;
 class WorkingHoursYearlyViewRepository extends AbstractWorkingHoursViewRepository
 {
 
-    protected const SQL_SELECT = <<<SQL
+    protected const string SQL_SELECT = <<<SQL
         select
             "Jahr" as "period",
             "Gesamtarbeitszeit" as "totalHours",
@@ -19,7 +19,7 @@ class WorkingHoursYearlyViewRepository extends AbstractWorkingHoursViewRepositor
             "Überstunden" as "overtime"
         from "Arbeitszeiten - Jahr"
 SQL;
-    protected const SQL_WHERE  = ' where "Jahr" = ?';
+    protected const string SQL_WHERE  = ' where "Jahr" = ?';
 
     public function __construct(PDO $database)
     {
diff --git a/api/tests/api.suite.dist.yml b/api/tests/api.suite.dist.yml
index 3c4624f..ea87ebd 100644
--- a/api/tests/api.suite.dist.yml
+++ b/api/tests/api.suite.dist.yml
@@ -3,6 +3,6 @@ modules:
     enabled:
         - \Helper\Api
         - REST:
-              url: http://localhost:8091/
+              url: http://api:80/
               depends: PhpBrowser
               part: Json
\ No newline at end of file
diff --git a/api/tests/unit/Controller/WorkingHoursControllerTest.php b/api/tests/unit/Controller/WorkingHoursControllerTest.php
index 17ff3b8..e6b9903 100644
--- a/api/tests/unit/Controller/WorkingHoursControllerTest.php
+++ b/api/tests/unit/Controller/WorkingHoursControllerTest.php
@@ -4,14 +4,12 @@ namespace TorstenHettstedt\TimekeepingApi\Tests\Unit\Controller;
 
 use Codeception\Attribute\DataProvider;
 use Exception;
-use PHPUnit\Framework\MockObject\MockObject;
 use Psr\Container\ContainerExceptionInterface;
 use Psr\Container\ContainerInterface;
 use Psr\Container\NotFoundExceptionInterface;
 use Slim\Exception\HttpBadRequestException;
 use Slim\Exception\HttpNotFoundException;
 use Slim\Psr7\Request;
-use Slim\Psr7\Response;
 use TorstenHettstedt\TimekeepingApi\Controller\HttpConflictRequestException;
 use TorstenHettstedt\TimekeepingApi\Controller\NotDatabasesException;
 use TorstenHettstedt\TimekeepingApi\Controller\WorkingHoursController;
@@ -25,10 +23,6 @@ class WorkingHoursControllerTest extends AbstractControllerTest
     public const    string NEW_DATE              = '2020-04-01';
     public const    string NEW_INTERVAL          = '07:59:00';
 
-    protected ContainerInterface  $container;
-    protected Request             $request;
-    protected Response|MockObject $response;
-
     /**
      * @throws Exception
      * @throws \PHPUnit\Framework\MockObject\Exception